Bigtable: add an option to pass in row filter text proto for use in template#37632
Bigtable: add an option to pass in row filter text proto for use in template#37632damccorm merged 5 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @mutianf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Bigtable I/O connector by adding support for specifying row filters as a text proto string. This feature allows users to define complex row filters dynamically, particularly useful in templated pipelines where filter configurations might be provided as strings. The change introduces a new method Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
...a/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Outdated
Show resolved
Hide resolved
| ValueProvider<RowFilter> rowFilter = readOptions.getRowFilter(); | ||
| return rowFilter != null && rowFilter.isAccessible() ? rowFilter.get() : null; | ||
| ValueProvider<RowFilter> rowFilterValueProvider = readOptions.getRowFilter(); | ||
| RowFilter rowFilter = null; |
There was a problem hiding this comment.
Chain.Builder chain = Chain.newBuilder()
if (rowFilterValueProvider != null && rowFilterValueProvider.isAccessible()) {
chain.addFilter(rowFilterValueProvider.get());
}
if (textFilterValueProvider != null && textFilterValueProvider.isAccessible()) {
chain.addFilter(...)
}
switch (chain.getFilterCount()) {
case 0: return null;
case 1: return chain.getFilter(0);
default: return chain.build()
}
|
I'll wait for checks to complete, then merge |
3 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.